ref(node-experimental): Use sdk-trace-base instead of sdk-trace-node#9070
Merged
ref(node-experimental): Use sdk-trace-base instead of sdk-trace-node#9070
Conversation
AbhiPrasad
approved these changes
Sep 20, 2023
b78d17b to
ef37c46
Compare
Contributor
size-limit report 📦
|
Also update all OTEL dependencies to latest to align these properly.
ef37c46 to
aaae6b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also update all OTEL dependencies to latest to align these properly.
The sdk-trace-node package actually just wraps sdk-trace-base, adds some default exports (that we do not need) + sets the async local storage context manager by default (which we overwrite anyhow).
So we can cut down on one dependency there and make this a tiny bit easier.
I also made a central
OtelSpantype in node-experimental to avoid using this everywhere throughout the codebase.