fix(node-otel): Refactor OTEL span reference cleanup#9000
Merged
Conversation
3d53051 to
34985ce
Compare
Contributor
size-limit report 📦
|
7b2826c to
1825c15
Compare
452607a to
871e709
Compare
871e709 to
7da7fc4
Compare
AbhiPrasad
approved these changes
Sep 12, 2023
Contributor
AbhiPrasad
left a comment
There was a problem hiding this comment.
Really good change, makes sense to me. We might need to do similar in the other SDKs as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update: This PR was updated with new behaviour.
This PR updates the span reference cleanup to take into account if a span is/may still be referenced somewhere else.
Previously, whenever a span finished we removed the reference from the map, to clean up and avoid memory leaks.
However, it seems that sometimes spans are ended before a child span is started (at least the hooks may fire in this order). This leads to the potential case where a parent that should exist cannot be found, thus creating a new transaction instead of a span.
With this change, we keep more information in our span map, in order to clear sub-spans (=not transactions) only when the root span (=transaction) is finished.