test(overhead): Stop loading api.lorem.space images#8833
Merged
Conversation
Contributor
size-limit report 📦
|
This site is dead, lets remove the image loading from it. Not sure if loading images is required for the overhead metrics though...
8668386 to
4a5a2bb
Compare
mydea
approved these changes
Aug 18, 2023
Member
mydea
left a comment
There was a problem hiding this comment.
I added some static (licence free!) images instead, let's merge this and get this fixed 🚀
Member
|
closing & reopening this in order to run the overhead test (sadly it currently only picks up the ci-overhead-metrics label when it is added to the PR at create time 😬 also something to think about...) |
Contributor
Replay SDK metrics 🚀Latest data for: 3b92636
*) pp - percentage points - an absolute difference between two percentages.
Last updated: Fri, 18 Aug 2023 07:15:06 GMT |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This site is dead, lets remove the image loading from it. Not sure if loading images is required for the overhead metrics though...