ref(replay): Ensure we only clear for buffer mode#8744
Merged
Conversation
lforst
approved these changes
Aug 7, 2023
Lms24
approved these changes
Aug 7, 2023
e2149de to
9813ebd
Compare
Contributor
size-limit report 📦
|
billyvg
reviewed
Aug 7, 2023
|
|
||
| try { | ||
| if (isCheckout) { | ||
| if (isCheckout && replay.recordingMode === 'buffer') { |
Member
There was a problem hiding this comment.
Is it possible we rely on this behavior in session mode as well?
e.g. when we call stopRecording, and then restart it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This shouldn't happen, but it makes sense to guard so we only clear the event buffer cache on checkouts when in
buffermode. I guess the behavior of rrweb is not 100% defined in that it cannot generate a new checkout in non-buffer mode 🤔 better safe than sorry.FWIW I don't think that is the cause of our too-long-empty-replays issue right now, but 🤷 it doesn't hurt anyhow to be cautious here.