ref: Allow withSentryConfig to accept async config function#8721
Merged
kamilogorek merged 1 commit intodevelopfrom Aug 2, 2023
Merged
ref: Allow withSentryConfig to accept async config function#8721kamilogorek merged 1 commit intodevelopfrom
kamilogorek merged 1 commit intodevelopfrom
Conversation
lforst
approved these changes
Aug 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified one template to use the async function instead, as adding an additional variant to an already bloated integration test runner felt meh.
Note that type from #7444 is incorrect.
It should be:
and not:
Note #2: async function handling works for
next >= 12.1only: https://nextjs.org/docs/app/api-reference/next-config-js/pageExtensionsVerified the behavior locally using provided sample config from the original issue.
Fixes #7444