test: Use getLocalTestUrl instead of getLocalTestPath for xhr tests#8719
Merged
test: Use getLocalTestUrl instead of getLocalTestPath for xhr tests#8719
getLocalTestUrl instead of getLocalTestPath for xhr tests#8719Conversation
Hoping this unflakes some stuff...
Contributor
size-limit report 📦
|
AbhiPrasad
approved these changes
Aug 2, 2023
Contributor
AbhiPrasad
left a comment
There was a problem hiding this comment.
Should we stop using getLocalTestPath across the board then?
Lms24
approved these changes
Aug 2, 2023
Member
Lms24
left a comment
There was a problem hiding this comment.
Can you explain why getLocalTestPath was causing flakes?
Member
Author
I can't 😅 it was just a guess that it could be related to file URLs and get, it may not be the problem, but I figured it doesn't hurt. Probably we can/should move all/most usage over because it is more "realistic" to a real-world usage IMHO. Just saw a few flakes here and there for the get tests etc. and don't really see much in the tests that could explain this 😬 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hoping this unflakes some stuff...
Closes #8717