ref(e2e): Update Remix recipe build command#8611
Closed
priscilawebdev wants to merge 1 commit intodevelopfrom
Closed
ref(e2e): Update Remix recipe build command#8611priscilawebdev wants to merge 1 commit intodevelopfrom
priscilawebdev wants to merge 1 commit intodevelopfrom
Conversation
Member
|
We had to revert this, because this starts the server and then hangs because it doesn't complete. I think what we have to do is setup playwright (similar to e.g. the nextjs tests), where we start the next server, test that we can access e.g. localhost:xxxx/, and then close the server. |
Member
Author
|
@mydea did you have to revert this? but it was not merged, was it? I will setup playwright. Thank you 🙏 |
Member
Revert in the sense of remove the |
Member
|
Replaced by #8633 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
without
&& pnpm startthe test will always pass as the error really only appears when lauching the application.Related to #8286