test: Only run specified integration tests with firefox#8603
Merged
Conversation
fec22b8 to
3660513
Compare
This changes it so you have to mark integration tests you want to run in firefox with `@firefox`. We've been skipping a few of them and had often flakiness issues, probably due to microsoft/playwright#12182.
e89c47e to
d02b5cc
Compare
Contributor
size-limit report 📦
|
mydea
commented
Jul 24, 2023
| flushMaxDelay: 200, | ||
| minReplayDuration: 0, | ||
| slowClickTimeout: 3100, | ||
| slowClickTimeout: 3500, |
Member
Author
There was a problem hiding this comment.
changed this as it was sometimes flaky with the 3000 min threshold.
AbhiPrasad
approved these changes
Jul 24, 2023
Contributor
AbhiPrasad
left a comment
There was a problem hiding this comment.
yeah this seems fine for me
This was referenced Jul 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a possible fix for #8589, this sets up our integration tests to only run tests in firefox when the test contains
@firefox. This way, we manually tag tests we want to run in firefox, as the tests are quite often flaky.We may think about reverting this once microsoft/playwright#12182 is fixed.
Note that to do this, I changed our usage of
browserto instead useproject(which appears anyhow the recommended way to do this nowadays).Note that this also has the advantage that the "default" and chromium are the same thing now, previously when running
yarn testit would actually use chromium under the hood but not generate snapshots etc. as chromium, now this should be more explicit.I've only added stuff that had explicit firefox things right now (e.g. stacktrace stuff, ...), not sure if there are other things we also want to make sure to run in FF?