chore(test): Test Remix and NextJS SDKs on Node 20.#8577
Merged
AbhiPrasad merged 15 commits intodevelopfrom Jul 24, 2023
Merged
chore(test): Test Remix and NextJS SDKs on Node 20.#8577AbhiPrasad merged 15 commits intodevelopfrom
AbhiPrasad merged 15 commits intodevelopfrom
Conversation
72dfd7c to
a9368dd
Compare
Contributor
size-limit report 📦
|
c0a059f to
4e466c2
Compare
mydea
reviewed
Jul 21, 2023
| } | ||
|
|
||
| private _closeServer(): Promise<void> { | ||
| return this._terminator.terminate(); |
Member
There was a problem hiding this comment.
just to be clear, do we not need to call this.server.close() anymore, is that handled by the terminator?
Collaborator
Author
There was a problem hiding this comment.
mydea
approved these changes
Jul 21, 2023
4e466c2 to
6ae5375
Compare
3d3812e to
5f6316b
Compare
AbhiPrasad
approved these changes
Jul 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #7906
Made updates about test server termination. Integrated
http-terminatoras closing all sockets / cancelling pending requests and such produced plenty of maintenance code.Also, found out that
portfinderdoes not work well in Node 20, and causes flakiness. Removed it from Remix and NextJS tests, as it can be replaced withapp.listen(0, ...).