feat(core): Allow multiplexed transport to send to multiple releases#8559
Merged
AbhiPrasad merged 2 commits intogetsentry:developfrom Jul 17, 2023
Merged
Conversation
AbhiPrasad
approved these changes
Jul 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The multiplexed transport can already route events to different or multiple DSNs but we also need to be able to route to specific releases too.
In a page with micro-frontends, it's possible (and probably even quite common) to be using the same dependency multiple times but different versions (ie. different releases). Depending on where an error occurs we might want to send an event to
cool-internal-components@1.0.0-betaorcool-internal-components@0.9.0at the same DSN.This PR:
makeOverrideReleaseTransportwhich can used to wrap a transport and override the release on all eventsmakeMultiplexedTransportso it now creates a transport for each unique dsn/release pairmakeOverrideReleaseTransportwhenever a release is returned from the callback