Conversation
mydea
approved these changes
Jul 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I looked into the linked errors integration to implement support for Aggregate erros I noticed that in the node linked errors integration we had an
awaitthat did nothing.This was a bit curios to me since all of the functions in the node linked errors integration were async just because of that await. Looking into it some more it seems that we used the wrong funciton of the context lines integration to attach source context. We were only attaching source context if the file was in our file cache - this operation is synchronous. We basically just called the wrong fuction of the context lines integration (
addSourceContextToFramesinstead ofaddSourceContext).This pr changes the node linked errors integration to add source (cached AND uncached) source context to linked errors after they have been attached to the event. Also gets rid of some unnecessary sync promise, async await shenanigans.