ref(serverless): Extract propagation context#8429
Merged
AbhiPrasad merged 2 commits intodevelopfrom Jul 4, 2023
Merged
Conversation
mydea
reviewed
Jun 30, 2023
Comment on lines
+281
to
+284
| const sentryTrace = | ||
| eventWithHeaders.headers && isString(eventWithHeaders.headers['sentry-trace']) | ||
| ? eventWithHeaders.headers['sentry-trace'] | ||
| : undefined; |
Member
There was a problem hiding this comment.
Suggested change
| const sentryTrace = | |
| eventWithHeaders.headers && isString(eventWithHeaders.headers['sentry-trace']) | |
| ? eventWithHeaders.headers['sentry-trace'] | |
| : undefined; | |
| const sentryTrace = eventWithHeaders.headers?.['sentry-trace'] || undefined; |
as we are already using optional chaining, might as well use it here as well ;)
Contributor
Author
There was a problem hiding this comment.
We need the isString check - see #8425 (comment) for more details.
mydea
reviewed
Jun 30, 2023
| const dynamicSamplingContext = baggageHeaderToDynamicSamplingContext(baggageHeader); | ||
|
|
||
| const hub = getCurrentHub(); | ||
| const sentryTrace = req.headers && isString(req.headers['sentry-trace']) ? req.headers['sentry-trace'] : undefined; |
Member
There was a problem hiding this comment.
Suggested change
| const sentryTrace = req.headers && isString(req.headers['sentry-trace']) ? req.headers['sentry-trace'] : undefined; | |
| const sentryTrace = req.headers?.['sentry-trace'] || undefined; |
mydea
approved these changes
Jul 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref #8352
Introduce the
tracingContextFromHeaders(first used in #8422) to simplify how trace context is generated by serverless tracing handlers. Then set the propagation context accordingly.