Skip to content

ref: Remove undefined checks for hub.getScope()#8401

Merged
AbhiPrasad merged 1 commit intodevelopfrom
abhi-no-undef-scope
Jun 26, 2023
Merged

ref: Remove undefined checks for hub.getScope()#8401
AbhiPrasad merged 1 commit intodevelopfrom
abhi-no-undef-scope

Conversation

@AbhiPrasad
Copy link
Copy Markdown
Contributor

@AbhiPrasad AbhiPrasad commented Jun 23, 2023

In #7551 I made it so that scope was always defined when calling hub.getScope(). This patch refactors some code (mostly tests) to not check if scope is undefined anymore.

We no longer need to do

const span = hub.getScope()?.getSpan();

or

const scope = hub.getScope();
if (scope) {
  scope.addBreadcrumb(...)
}

@AbhiPrasad AbhiPrasad requested review from a team, Lms24 and stephanie-anderson and removed request for a team June 23, 2023 18:18
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 23, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 21.3 KB (+0.61% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 66.43 KB (+0.46% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.82 KB (+0.59% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 58.9 KB (+0.53% 🔺)
@sentry/browser - Webpack (gzipped + minified) 21.43 KB (+0.48% 🔺)
@sentry/browser - Webpack (minified) 69.87 KB (+0.51% 🔺)
@sentry/react - Webpack (gzipped + minified) 21.46 KB (+0.45% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 49.38 KB (+0.21% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 28.88 KB (+0.33% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 27.11 KB (+0.33% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 49.34 KB (+0.01% 🔺)
@sentry/replay - Webpack (gzipped + minified) 43.1 KB (+0.07% 🔺)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 68.47 KB (+0.17% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 61.38 KB (+0.2% 🔺)

@AbhiPrasad AbhiPrasad merged commit 22b5887 into develop Jun 26, 2023
@AbhiPrasad AbhiPrasad deleted the abhi-no-undef-scope branch June 26, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mydea mydea mydea approved these changes

@Lms24 Lms24 Lms24 approved these changes

@stephanie-anderson stephanie-anderson Awaiting requested review from stephanie-anderson stephanie-anderson was automatically assigned from getsentry/team-javascript-sdks

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AbhiPrasad @mydea @Lms24