test(react): Add tests for react-router createHashRouter usage.#8362
Merged
AbhiPrasad merged 5 commits intodevelopfrom Jun 22, 2023
Merged
test(react): Add tests for react-router createHashRouter usage.#8362AbhiPrasad merged 5 commits intodevelopfrom
react-router createHashRouter usage.#8362AbhiPrasad merged 5 commits intodevelopfrom
Conversation
d90efef to
f631c6f
Compare
Contributor
size-limit report 📦
|
df34772 to
98d0b71
Compare
AbhiPrasad
reviewed
Jun 20, 2023
Contributor
AbhiPrasad
left a comment
There was a problem hiding this comment.
Can we add some integration tests that validate the transaction name being set correctly?
98d0b71 to
da57a94
Compare
react-router createHashRouter usage.react-router createHashRouter usage.
84f9466 to
a6ce831
Compare
AbhiPrasad
reviewed
Jun 21, 2023
| .toBe(200); | ||
| }); | ||
|
|
||
| test('Sends a pageload transaction to Sentry', async ({ page }) => { |
Contributor
There was a problem hiding this comment.
Now that I see the integration test, I'm a bit hesistant to add the entire app + playwright under the react package tests for maintenance concerns.
Could we just check the transaction name in this test and the navigation test? Sorry for making you add the entire app - but not sure if it's worth to keep it.
Contributor
Author
There was a problem hiding this comment.
No worries at all, I agree, this ended up with so much code quite fastly. Which I tested now with 2 lines in the e2e test. 😅 Anyways we now have a PoC in case we need to integration test wider extent of React SDK in the future.
faa5f29 to
63dd97d
Compare
AbhiPrasad
approved these changes
Jun 22, 2023
Contributor
AbhiPrasad
left a comment
There was a problem hiding this comment.
Thanks @onurtemizkan!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See comment: #8317 (comment)
Resolves: #6251
Resolves: #8317
Docs Update: getsentry/sentry-docs#7218