meta(changelog): Update changelog for 7.55.0#8318
Merged
AbhiPrasad merged 14 commits intomasterfrom Jun 13, 2023
Merged
Conversation
This is causing some low-value replays. If you search sentry for replays with duration < 5 seconds, you will see that most of them are re-newed sessions from idle that only have a "keydown" breadcrumb. I suspect users are alt-tabbing out of an idle Sentry page. Removing for now until we have a better way to detect when a session is truly resumed via keydown event.
[Gitflow] Merge master into develop
… to unknown routes (#8278) Fix a possible scenario in which transaction names can have query params, namely a navigation to an unknown route.
Update the readme now that we're compatible with more adapters than just the Node adapter. Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
More specific types for our replay recording events. These are exported so that our UI can use them as well. 
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 4.0.0 to 4.0.5. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v4.0.5/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v4.0.5/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
Theres an edge case where a buffered session becomes expired, an error comes in, the link from error to replay is lost because a new session is created due to the session being expired. We should either ignore the max session life for a buffered session, or possibly check/refresh session when an error comes in.
This moves the slow click detection out of GA and makes it generally available. You can opt-out of this by setting `slowClickTimeout: 0`. It also adds `disabled` & `aria-disabled` attributes to captured DOM elements. note: We now capture this for `<a>`, `<button>` and `<input[type=button]>`/`<input[type=submit]>`. Closes #8295
Before submitting a pull request, please take a look at our [Contributing](https://github.com/getsentry/sentry-javascript/blob/master/CONTRIBUTING.md) guidelines and verify: - [ ] If you've added code that should be tested, please add tests. - [ ] Ensure your code lints and the test suite passes (`yarn lint`) & (`yarn test`).
Not sure how this happened and how that didn't fail before, but this is failing on master as of now...
mydea
approved these changes
Jun 13, 2023
Member
mydea
left a comment
There was a problem hiding this comment.
I think this is fine, this is nothing we are pushing for now and should not impact users really. 🚢
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if the replay stuff about slow clicks deserved a separate call out - so decided on a simpler changelog. Can change that if y'all think different.