Skip to content

test(replay): Skip firefox for flakey tests#8222

Merged
billyvg merged 1 commit intodevelopfrom
test-replay-fix-flakey-tests
May 30, 2023
Merged

test(replay): Skip firefox for flakey tests#8222
billyvg merged 1 commit intodevelopfrom
test-replay-fix-flakey-tests

Conversation

@billyvg
Copy link
Copy Markdown
Member

@billyvg billyvg commented May 26, 2023

These tests seem to only flake on firefox?

These tests seem to only flake on firefox?
@github-actions
Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 21.05 KB (+0.14% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 65.69 KB (+0.1% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.59 KB (+0.13% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 58.16 KB (+0.14% 🔺)
@sentry/browser - Webpack (gzipped + minified) 21.21 KB (+0.18% 🔺)
@sentry/browser - Webpack (minified) 69.08 KB (+0.06% 🔺)
@sentry/react - Webpack (gzipped + minified) 21.23 KB (+0.19% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 49.16 KB (+0.1% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 28.67 KB (+0.11% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.91 KB (+0.11% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 48.25 KB (+1.33% 🔺)
@sentry/replay - Webpack (gzipped + minified) 41.96 KB (+1.2% 🔺)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 67.22 KB (+1.08% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 60.12 KB (+1.24% 🔺)

@billyvg billyvg marked this pull request as ready for review May 26, 2023 15:47
@billyvg billyvg self-assigned this May 29, 2023
@billyvg billyvg added the Package: replay Issues related to the Sentry Replay SDK label May 29, 2023
@billyvg
Copy link
Copy Markdown
Member Author

billyvg commented May 29, 2023

Detect flaky tests ran twice without any issues

@billyvg billyvg requested a review from Lms24 May 29, 2023 16:47
Copy link
Copy Markdown
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still wonder why PW+FF is so flakey with Replay...

@billyvg
Copy link
Copy Markdown
Member Author

billyvg commented May 30, 2023

Yeah it seems that clicks seem to flake with FF

@billyvg billyvg merged commit e95e574 into develop May 30, 2023
@billyvg billyvg deleted the test-replay-fix-flakey-tests branch May 30, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Package: replay Issues related to the Sentry Replay SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants