Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
handleUnknownRoutesoption to thesentryHandleserver request handler. The option defaults tofalsewhich would effectively reduce noise, such as random bot requests. Previously such requests would yield e.g.GET nulltransactions because they could not be matched to an existing route by the framework. See #8199Note: Users can right now also drop these transactions in
ignoreTransactionsorbeforeSendTransactionbut I think we should pre-filter them by default but give them the option to still monitor such requests if they choose to do so.:Example:
Users register a custom handler (or a handler from a library)
which "understands" requests that are not mapped to a SvelteKit route. This request would not lead to a transaction, unless
handleUnknownRouteswas set totrue.resolves #8199