fix(node): remove new URL usage in Undici integration#8147
Merged
AbhiPrasad merged 1 commit intodevelopfrom May 17, 2023
Merged
fix(node): remove new URL usage in Undici integration#8147AbhiPrasad merged 1 commit intodevelopfrom
AbhiPrasad merged 1 commit intodevelopfrom
Conversation
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #8145
It seems that there are some scenarios where you can pass in an invalid URL to
fetch, which breaks our integrations. For example, a URL likehttp://a-url-that-no-exists.com//(notice the double slashes at the end).Not sure if this is something Node needs to fix, but for now we need to fix to make sure we don't crash users.
Big thanks to @Lms24 for the suggestion to use
parseUrl!