fix(tracing): Change where content-length gets added#8139
Merged
AbhiPrasad merged 2 commits intodevelopfrom May 17, 2023
Merged
fix(tracing): Change where content-length gets added#8139AbhiPrasad merged 2 commits intodevelopfrom
AbhiPrasad merged 2 commits intodevelopfrom
Conversation
Response content length can't be added upon span creation since the response doesn't exist yet, this should add content-length on the subsequent call to the handler after the fetch/xhr has finished.
Contributor
size-limit report 📦
|
Lms24
approved these changes
May 17, 2023
AbhiPrasad
approved these changes
May 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Response content length can't be added upon span creation since the response doesn't exist yet, this should add content-length on the subsequent call to the handler after the fetch/xhr has finished.
@narsaynorath this might need test changes, if you can carry it forward 🙏