fix(node): Add LRU map for tracePropagationTargets calculation#8130
Merged
AbhiPrasad merged 1 commit intodevelopfrom May 16, 2023
Merged
fix(node): Add LRU map for tracePropagationTargets calculation#8130AbhiPrasad merged 1 commit intodevelopfrom
AbhiPrasad merged 1 commit intodevelopfrom
Conversation
lforst
approved these changes
May 16, 2023
Lms24
approved these changes
May 16, 2023
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #8129
Adds an LRU Map so that we don't let the cached items grow infinitely.
Important to note that
shouldAttachTraceDataandshouldCreateSpanbehaviour is basically identical now other than the map and executor used, but I didn't refactor further because I felt the abstraction is more confusing than just having this simple duplication.