ref(serverless): Remove relay extension from AWS layer#8080
Merged
sl0thentr0py merged 1 commit intodevelopfrom May 16, 2023
Merged
ref(serverless): Remove relay extension from AWS layer#8080sl0thentr0py merged 1 commit intodevelopfrom
sl0thentr0py merged 1 commit intodevelopfrom
Conversation
Contributor
size-limit report 📦
|
c022489 to
3d02e93
Compare
4 tasks
Lms24
reviewed
May 15, 2023
| 'build/aws/dist-serverless/nodejs/node_modules/@sentry/serverless/dist/awslambda-auto.js', | ||
| ); | ||
|
|
||
| const version = run("cat package.json | jq --raw-output '.version'", { stdio: 'pipe' }).trim(); |
Member
There was a problem hiding this comment.
h: the jq command errors for me locally because I don't have jq installed on my machine. Can we make sure that this doesn't become a requirement for a successful local build? I think we can either import/require the or read and JSON.parse the package.json instead to get the version.
Member
There was a problem hiding this comment.
Another idea: I just saw that read-pkg is still registered as a dev dependency but we don't seem to use it anywhere. So we could use it to read the package.json here, too. (Or alternatively, let's get rid of it)
Member
Author
There was a problem hiding this comment.
- removed
read-pkg - imported
versionfrompackage.json(needed"resolveJsonModule": trueintsconfig.json)
55ae2f5 to
234a678
Compare
we're reverting back to the older setup since the whole 'relay as AWS extension' experiment didn't really work out. * revert port override in DSN * remove gh action that bundles relay * zip in place as part of `buildLambdaLayer` part of getsentry/team-webplatform-meta#58
234a678 to
85a6e60
Compare
Lms24
approved these changes
May 16, 2023
Member
Lms24
left a comment
There was a problem hiding this comment.
Thanks for adjusting, LGTM now and it builds successfully for me. Just to confirm: You testes this on AWS, right? especially the aws-auto command?
Member
Author
|
yep, tested manually, will test whole prod flow once released |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we're reverting back to the older setup since the whole 'relay as AWS extension' experiment didn't really work out.
buildLambdaLayerpart of getsentry/team-webplatform-meta#58
see python PR - getsentry/sentry-python#2068