feat(replay): Improve click target detection#8026
Merged
Conversation
Contributor
size-limit report 📦
|
1484170 to
8c5a624
Compare
8c5a624 to
ddf7aa0
Compare
billyvg
reviewed
May 4, 2023
Member
billyvg
left a comment
There was a problem hiding this comment.
Code looks good to me but I'd like to test it out a bit first and see how the data looks.
billyvg
approved these changes
May 5, 2023
Member
billyvg
left a comment
There was a problem hiding this comment.
Tested it on sentry.io and it seems pretty reasonable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does two things:
This is rather defensive for now, by only checking for button & a. This will not check for general interactivity - there are other cases to look for as well, e.g.
[tabindex]etc. However, IMHO this has also potential to break, if people have weird HTML. So I think this should be a good enough start with very low potential for false positives.Fixes #7659