Skip to content

fix(replay): Check relative URLs correctly#8024

Merged
billyvg merged 1 commit intodevelopfrom
fn/check-full-url-replay-body
May 11, 2023
Merged

fix(replay): Check relative URLs correctly#8024
billyvg merged 1 commit intodevelopfrom
fn/check-full-url-replay-body

Conversation

@mydea
Copy link
Copy Markdown
Member

@mydea mydea commented May 3, 2023

As mentioned by @ryan953 here, we should check relative URLs properly as well for capturing network details.

@mydea mydea added Type: Bug Package: replay Issues related to the Sentry Replay SDK labels May 3, 2023
@mydea mydea requested a review from billyvg May 3, 2023 08:36
@mydea mydea self-assigned this May 3, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 3, 2023 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 21.01 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 65.62 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.55 KB (-0.01% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 58.08 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 21.16 KB (0%)
@sentry/browser - Webpack (minified) 69.03 KB (0%)
@sentry/react - Webpack (gzipped + minified) 21.18 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 49.09 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 28.64 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.86 KB (-0.01% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 46.94 KB (+0.17% 🔺)
@sentry/replay - Webpack (gzipped + minified) 40.76 KB (+0.24% 🔺)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 65.82 KB (+0.12% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 58.71 KB (+0.13% 🔺)

@mydea mydea force-pushed the fn/check-full-url-replay-body branch from 15fcc02 to ff84d97 Compare May 3, 2023 11:12
@mydea mydea mentioned this pull request May 3, 2023
Merged
@mydea mydea force-pushed the fn/check-full-url-replay-body branch from ff84d97 to 3bc3fe1 Compare May 4, 2023 06:56
@mydea
Copy link
Copy Markdown
Member Author

mydea commented May 4, 2023

Alternatively, we could also do the URL transformation to absolute URL in the breadcrumbs themselves, so actually send the absolute URL instead of the relative one. Would that be helpful/make sense cc @ryan953 ?

@billyvg
Copy link
Copy Markdown
Member

billyvg commented May 4, 2023 •
edited
Loading

Alternatively, we could also do the URL transformation to absolute URL in the breadcrumbs themselves, so actually send the absolute URL instead of the relative one. Would that be helpful/make sense cc @ryan953 ?

I pushed back on this awhile back, but I think we should go ahead and do this as it'll make the data consistent for the UI as well as for users when configuring the allow URLs.

edit though maybe we do want the URLs to match how the user calls fetch() with shrug

@billyvg
Copy link
Copy Markdown
Member

billyvg commented May 10, 2023

We talked about this and decided to move forward with this and not modify user's input to fetch() for now.

@billyvg billyvg merged commit 9a267eb into develop May 11, 2023
@billyvg billyvg deleted the fn/check-full-url-replay-body branch May 11, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@billyvg billyvg billyvg approved these changes

Assignees

@billyvg billyvg

@mydea mydea

Labels

Package: replay Issues related to the Sentry Replay SDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mydea @billyvg