fix(ember): Ensure only one client is created & Replay works#7712
Merged
fix(ember): Ensure only one client is created & Replay works#7712
Conversation
Lms24
approved these changes
Apr 3, 2023
Member
Lms24
left a comment
There was a problem hiding this comment.
I have no idea about Ember-specifics but the change makes sense to me.
packages/ember/addon/instance-initializers/sentry-performance.ts
Outdated
Show resolved
Hide resolved
Contributor
size-limit report 📦
|
With the new `addIntegration` API, we don't need to create multiple clients anymore, which also potentially broke replays.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses the new
addIntegrationAPI to add browser tracing, which means we do not need to callSentry.init()twice, which lead to issues as replay relies on the client remaining consistent.Fixes #7640