Merged
Conversation
Contributor
size-limit report 📦
|
mydea
approved these changes
Mar 27, 2023
Contributor
Author
|
Yeah we should probably revert this too. However, I don't think that this would realistically change anything. |
|
Cool, maybe it isn't this change that got us into trouble. Started a discussion here: #8370 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7500
In #7167 we put
abs_pathonto the stack frame object in error events.abs_pathis used by symbolicator to resolve source maps and since we now have it on the stack frame it is not backfilled anymore in Relay.This change caused source maps to break in the Next.js SDK because we do some frame rewriting to account for asset prefixes and URL decoding issues.