fix(sveltekit): Handle nested server calls in sentryHandle#7598
Merged
fix(sveltekit): Handle nested server calls in sentryHandle#7598
sentryHandle#7598Conversation
7ff774a to
8c0762e
Compare
8c0762e to
6bc071e
Compare
sentryHandlesentryHandle
AbhiPrasad
approved these changes
Mar 29, 2023
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we always created a new domain when entering the
sentryHandlefunction. This caused "nested" SvelteKit Server calls to create new transaction whenever a new domain was created in thesentryHandlefunction because the active span is bound to the domain. This PR introduces a check if there is an active transaction, in which case we just execute the handler and don't create a new domain, as we are already in this active domain.As a result, nested SK server calls become a span of the parent server call instead of a new transaction:
ref #7526