fix(sveltekit): Termporarily disable serverside load tracing#7587
Merged
fix(sveltekit): Termporarily disable serverside load tracing#7587
Conversation
AbhiPrasad
approved these changes
Mar 23, 2023
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We discovered that our serverside
handleLoadWithSentrywrapper caused two distinct transactions being created on page loads - one for the page load request and one for theloadfunction (if one exists for that page). This shouldn't happen. We need to investigate how to fix this.As a short-term solution, we disable tracing on the serverside load wrapper to avoid quota usage increase for our users.
Note: I basically removed the
tracecall and added back the error reporting logic. However, I adjusted types to acceptServerLoadandLoadfunctions as discovered in #7581ref #7526