Skip to content

feat(replay): Capture replay mutation breadcrumbs & add experiment#7568

Merged
mydea merged 5 commits intodevelopfrom
fn/mutation-size
Mar 24, 2023
Merged

feat(replay): Capture replay mutation breadcrumbs & add experiment#7568
mydea merged 5 commits intodevelopfrom
fn/mutation-size

Conversation

@mydea
Copy link
Member

@mydea mydea commented Mar 22, 2023 •
edited by billyvg
Loading

Adds _experiments.mutationLimit to experiment with this.
This will result in any mutations with more than the given amount of mutations will trigger a full snapshot instead of an incremental one with a lot of mutations.

Closes #7530
Closes #7529

@mydea mydea added Type: Feature Package: replay Issues related to the Sentry Replay SDK labels Mar 22, 2023
@mydea mydea requested review from Lms24 and billyvg March 22, 2023 14:01
@mydea mydea self-assigned this Mar 22, 2023
mydea
mydea commented Mar 22, 2023
View reviewed changes
billyvg
billyvg reviewed Mar 22, 2023
View reviewed changes
Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just some small 🚲 🏠

@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2023 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.57 KB (0%)
@sentry/browser - ES5 CDN Bundle (minified) 64.2 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.13 KB (-0.01% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 56.58 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 21.59 KB (0%)
@sentry/browser - Webpack (minified) 71.66 KB (0%)
@sentry/react - Webpack (gzipped + minified) 21.61 KB (-0.01% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified) 51.88 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 27.93 KB (0%)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.1 KB (0%)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 44.37 KB (+0.1% 🔺)
@sentry/replay - Webpack (gzipped + minified) 38.44 KB (+0.13% 🔺)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 62.59 KB (+0.08% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 56.1 KB (+0.07% 🔺)

@mydea
Copy link
Member Author

mydea commented Mar 22, 2023

I addressed the PR feedback @billyvg !

billyvg
billyvg approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@mydea mydea force-pushed the fn/mutation-size branch 4 times, most recently from 878f9a8 to c542a36 Compare March 24, 2023 09:24
@mydea mydea force-pushed the fn/mutation-size branch from c542a36 to 72bbefb Compare March 24, 2023 10:56
@mydea mydea merged commit a2103f3 into develop Mar 24, 2023
@mydea mydea deleted the fn/mutation-size branch March 24, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@billyvg billyvg billyvg approved these changes

@Lms24 Lms24 Lms24 approved these changes

Assignees

@mydea mydea

Labels

Package: replay Issues related to the Sentry Replay SDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add experiment for large mutations to use full snapshot Removing experiment for adding breadcrumbs for large mutations

3 participants

@mydea @billyvg @Lms24