fix(nextjs): Add tracing extension methods in wrapServerComponentWithSentry#7567
Merged
fix(nextjs): Add tracing extension methods in wrapServerComponentWithSentry#7567
wrapServerComponentWithSentry#7567Conversation
wrapServerComponentWithSentrywrapServerComponentWithSentry
Contributor
size-limit report 📦
|
435da44 to
48ec741
Compare
AbhiPrasad
approved these changes
Mar 22, 2023
timfish
approved these changes
Mar 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our E2E tests were failing because apparently we don't initialize a client while building a NextJS app. This caused the tracing extension methods to not be added, resulting in
startTransactionreturningundefined. Not sure if this is the best way to fix this but it seems to work (h/t @timfish for the fix).cc @lforst might be good if you take a look at this once you're back