feat(nextjs): Remove @sentry/tracing dependency from nextjs SDK#7561
Merged
AbhiPrasad merged 1 commit intogetsentry:developfrom Mar 22, 2023
Merged
feat(nextjs): Remove @sentry/tracing dependency from nextjs SDK#7561AbhiPrasad merged 1 commit intogetsentry:developfrom
@sentry/tracing dependency from nextjs SDK#7561AbhiPrasad merged 1 commit intogetsentry:developfrom
Conversation
AbhiPrasad
approved these changes
Mar 22, 2023
Member
|
Starting with this the next E2E tests started to fail: https://github.com/getsentry/sentry-javascript/actions/runs/4488629116/jobs/7893734269 Which we didn't see here because the E2E tests don't run on contributor PRs 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
@sentry/tracingdependency from the nextjs SDK.This involved:
@sentry/browserand@sentry/nodewere exporting the tracing types requiredaddTracingExtensionswhere this was previously taken care of by side-effects