feat(sveltekit): Automatically add BrowserTracing integration#7528
Merged
feat(sveltekit): Automatically add BrowserTracing integration#7528
BrowserTracing integration#7528Conversation
AbhiPrasad
approved these changes
Mar 20, 2023
Contributor
size-limit report 📦
|
still missing testing for tree-shaking kinda blocked on @sentry-internal/tracing
02d0e33 to
965e8e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR, the
BrowserTracingintegration is automatically added to the client SvelteKit SDK initialization. As in NextJS, tree-shaking will still work by replacing the__SENTRY_TRACING__flag withfalsewhen bundling. Tested this with the rollup replace plugin.Since we now use
addOrUpdateIntegrationin two SDKs, I opted to move it to the utils package.ref #7413