feat(tracing): Move registerErrorInstrumentation to @sentry/core#7494
Merged
AbhiPrasad merged 2 commits intogetsentry:developfrom Mar 17, 2023
Merged
feat(tracing): Move registerErrorInstrumentation to @sentry/core#7494AbhiPrasad merged 2 commits intogetsentry:developfrom
registerErrorInstrumentation to @sentry/core#7494AbhiPrasad merged 2 commits intogetsentry:developfrom
Conversation
registerErrorInstrumentation to core and call it from addTracingExtensionsregisterErrorInstrumentation to @sentry/core
AbhiPrasad
approved these changes
Mar 17, 2023
|
I can't find this information elsewhere, does this mean |
Collaborator
Author
|
The
|
Collaborator
Author
|
Sorry about that. It looks like this was missed from the migration guide. I've opened a PR to rectify this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addTracingExtensionsin@sentry/corefeels like our better named replacement foraddExtensionMethodshowever it didn't end up with the same functionality.While working on other tracing PRs I realised that we'd not moved
registerErrorInstrumentationto core and it makes more sense for it to be there.This PR moves
registerErrorInstrumentationto@sentry/coreand calls it fromaddTracingExtensionssince they are called together inaddExtensionMethods. It also adds a flag so errors are only instrumented once. This means we can safely calladdTracingExtensionsas many times as we like (ie. from integration constructors, etc).