fix(replay): Ensure network breadcrumbs have all data#7491
Merged
Conversation
billyvg
reviewed
Mar 16, 2023
billyvg
reviewed
Mar 16, 2023
ec4d094 to
07db898
Compare
Contributor
size-limit report 📦
|
dd9b2a9 to
a712cb4
Compare
a712cb4 to
e9ce530
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We actually noticed that the recent change to enrich the replay breadcrumbs doesn't work as expected.
The reason is that we weren't actually listening to the breadcrumb, but actually doing our own instrumentation.
This refactors this to fully use the new breadcrumb hook for this whole functionality. It also adds a bunch of tests to ensure this actually works as expected.