Conversation
…d" test for firefox This has been flakey... trace.status is sometimes undefined, lets skip for firefox
Contributor
size-limit report 📦
|
Lms24
reviewed
Mar 16, 2023
Member
Lms24
left a comment
There was a problem hiding this comment.
Hmm so #7442 didn't seem to fix all flakes?
Generally skipping firefox sounds reasonable to me as we've seen multiple times in the past that the flakes occur especially on FF.
Did you run the test by any chance for e.g. 100 times? We recently decided that we want to run integration test changes x100 to better check if flakes are gone. Wrapping the sentryTest in a good old for loop should do.
| sentryTest( | ||
| 'should finish pageload transaction when the page goes background', | ||
| async ({ browserName, getLocalTestPath, page }) => { | ||
| // TODO: This is flakey on firefox... trace.status is sometimes undefined |
Member
There was a problem hiding this comment.
I think we don't even need the TODO here. IMO it's unlikely that we'll fix this any time soon.
mydea
approved these changes
Mar 16, 2023
Member
mydea
left a comment
There was a problem hiding this comment.
Just got 3 (!) of these errors in a single PR, so let's get rid of this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been flakey... trace.status is sometimes undefined, lets skip for firefox