Skip to content

fix(profiling): catch sendProfile rejection#7446

Merged
AbhiPrasad merged 4 commits intodevelopfrom
fix/profiling/catch-sendprofile-rejection
Mar 14, 2023
Merged

fix(profiling): catch sendProfile rejection#7446
AbhiPrasad merged 4 commits intodevelopfrom
fix/profiling/catch-sendprofile-rejection

Conversation

@JonasBa
Copy link
Copy Markdown
Member

@JonasBa JonasBa commented Mar 13, 2023

This was causing errors when running sentry devserver in prod. Ensure we catch the envelope send in case of a network error.

@JonasBa JonasBa requested a review from AbhiPrasad March 13, 2023 18:35
Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
@github-actions
Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.4 KB (+0.01% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 63.27 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.97 KB (-0.02% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 56.18 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.64 KB (0%)
@sentry/browser - Webpack (minified) 67.41 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.66 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 48.66 KB (+0.23% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 27.74 KB (+0.37% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26 KB (+0.36% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 43.17 KB (0%)
@sentry/replay - Webpack (gzipped + minified) 37.19 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 61.29 KB (+0.16% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 54.37 KB (0%)

@AbhiPrasad AbhiPrasad merged commit 851037f into develop Mar 14, 2023
@AbhiPrasad AbhiPrasad deleted the fix/profiling/catch-sendprofile-rejection branch March 14, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants