ref(node): use native path module to infer path#7415
Merged
AbhiPrasad merged 1 commit intodevelopfrom Mar 20, 2023
Merged
Conversation
Contributor
size-limit report 📦
|
timfish
approved these changes
Mar 10, 2023
Member
Author
|
@timfish do you mind pulling the repo and running the test? I'm actually seeing an error locally and I have no idea why/how 🤔 |
Collaborator
|
All the tests pass my end! |
d3f4399 to
c025921
Compare
AbhiPrasad
approved these changes
Mar 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I initially profiled the code I noticed that the regexp used in splitPath function was dominating the profiles. Both basename and dirname from @sentry/utils were actually calling splitPath which executed the regexp - there were 3 call sites to basename and dirname, 1/3 was conditional. The "optimization" is to call path.parse once and extract each path component - this seems to have contributed to the largest win in terms of performance