ref(utils): test for webpack error before running replace#7412
Merged
AbhiPrasad merged 1 commit intodevelopfrom Mar 13, 2023
Merged
ref(utils): test for webpack error before running replace#7412AbhiPrasad merged 1 commit intodevelopfrom
AbhiPrasad merged 1 commit intodevelopfrom
Conversation
timfish
approved these changes
Mar 10, 2023
Contributor
size-limit report 📦
|
mydea
approved these changes
Mar 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we do not match a webpack error, then dont run replace as it will allocate a new string. This optimizes for non-webpack style errors. For cases where we would actually sanitize the string, calling test + replace makes it slightly slower.
Browser benchmarks (node benchmarks seem to confirm this)