feat(nextjs): Automatically resolve source of errors in dev mode#7294
Merged
feat(nextjs): Automatically resolve source of errors in dev mode#7294
Conversation
Contributor
size-limit report 📦
|
mydea
reviewed
Mar 1, 2023
| fullyParallel: true, | ||
| /* Fail the build on CI if you accidentally left test.only in the source code. */ | ||
| forbidOnly: !!process.env.CI, | ||
| /* Retry on CI only */ |
Member
There was a problem hiding this comment.
l: Should we update this comment as well?
mydea
reviewed
Mar 1, 2023
| return; | ||
| } | ||
|
|
||
| test('should have symbaolicated dev errors', async ({ page }) => { |
Member
There was a problem hiding this comment.
Suggested change
| test('should have symbaolicated dev errors', async ({ page }) => { | |
| test('should have symbolicated dev errors', async ({ page }) => { |
small typo ;)
Contributor
Author
There was a problem hiding this comment.
might have been hungry
mydea
reviewed
Mar 1, 2023
| * in the dev overlay. | ||
| */ | ||
| export async function devErrorSymbolicationEventProcessor(event: Event, hint: EventHint): Promise<Event | null> { | ||
| // Do to changes across Next.js versions, there are a million things that can go wrong here so we just try-catch the |
Member
There was a problem hiding this comment.
Suggested change
| // Do to changes across Next.js versions, there are a million things that can go wrong here so we just try-catch the | |
| // Due to changes across Next.js versions, there are a million things that can go wrong here so we just try-catch the |
mydea
approved these changes
Mar 1, 2023
Member
mydea
left a comment
There was a problem hiding this comment.
Nice! The regex is a bit 😬 but since it's only for dev that's fine. Cool improvement!
Lms24
approved these changes
Mar 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7286
This PR uses the Next.js dev server to resolve source maps in dev mode, eliminating the need to update them.
Before
After