fix(core): Exclude client reports from offline queuing#7226
Merged
mydea merged 3 commits intogetsentry:developfrom Feb 20, 2023
Merged
fix(core): Exclude client reports from offline queuing#7226mydea merged 3 commits intogetsentry:developfrom
mydea merged 3 commits intogetsentry:developfrom
Conversation
73dc1c2 to
5693635
Compare
mydea
reviewed
Feb 20, 2023
mydea
reviewed
Feb 20, 2023
Contributor
Replay SDK metrics 🚀
develop |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Revision | LCP | CLS | CPU | JS heap avg | JS heap max | netTx | netRx | netCount | netTime |
|---|---|---|---|---|---|---|---|---|---|
| c46c56c | +65.45 ms | -0.00 ms | +5.38 pp | +930.26 kB | +1.07 MB | +2.21 kB | +41 B | +1 | +91.29 ms |
| 7f4c4ec | +56.64 ms | -0.00 ms | +5.57 pp | +927.42 kB | +1.06 MB | +2.21 kB | +41 B | +1 | +110.83 ms |
| 00d2360 | +55.18 ms | +0.00 ms | +2.23 pp | +934.14 kB | +1.05 MB | +2.22 kB | +41 B | +1 | +71.65 ms |
*) pp - percentage points - an absolute difference between two percentages.
Last updated: Mon, 20 Feb 2023 10:14:54 GMT
Last updated: Mon, 20 Feb 2023 10:14:54 GMT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a user sets any
transportOptions, the transport is used directly to send client reports rather than beacon which means they can get queued by the offline transport wrapper.Client reports can be generated every time an event fails to send and these could fill the queue when offline and mean error events get dropped.
This PR modifies
forEachEnvelopeItemto allow short-cut out of the for loop if the callback returnstrue.