fix(replay): Export Replay from Sentry namespace in full CDN bundle#7119
Merged
fix(replay): Export Replay from Sentry namespace in full CDN bundle#7119
Conversation
AbhiPrasad
approved these changes
Feb 9, 2023
Contributor
Replay SDK metrics 🚀
develop |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Revision | LCP | CLS | CPU | JS heap avg | JS heap max | netTx | netRx | netCount | netTime |
|---|---|---|---|---|---|---|---|---|---|
| fc7b716 | +52.44 ms | +0.00 ms | +14.74 pp | +1.09 MB | +2.21 MB | +2.68 kB | +41 B | +1 | +89.64 ms |
*) pp - percentage points - an absolute difference between two percentages.
Last updated: Thu, 09 Feb 2023 14:43:10 GMT
Last updated: Thu, 09 Feb 2023 14:43:10 GMT
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be consistent with export namespaces, we want the
Replayintegration to be accesible underSentry.Replayin the full CDN bundles. This is backwards compatible as we still permitSentry.Integrations.Replayas well. We can remove it in v8.With this change, both CDN bundles containing replay (sdk+tracing+replay and sdk+replay) export from
Sentry.Replay. Only the addon bundle, which we already deprecated and don't mention in the docs anymore will only be available i nSentry.Integrations.Replay.