chore: make unit tests cacheable, fix package graph#7108
chore: make unit tests cacheable, fix package graph#7108mydea merged 8 commits intogetsentry:developfrom
Conversation
packages/integrations/package.json
Outdated
| "tslib": "^1.9.3" | ||
| }, | ||
| "devDependencies": { | ||
| "@sentry/browser": "7.36.0", |
There was a problem hiding this comment.
This relationship between these packages was missing and needed to be added to ensure task pipelines know what to do and in what order
packages/node/package.json
Outdated
| "tslib": "^1.9.3" | ||
| }, | ||
| "devDependencies": { | ||
| "@sentry/tracing": "7.36.0", |
There was a problem hiding this comment.
This relationship between these packages was missing and needed to be added to ensure task pipelines know what to do and in what order
|
@mydea I think this is just flakiness in the browser based integration testing, hopefully a re-run will resolve it. The relevant bits that my PR changed have passed |
|
Thanks! Green now |
meta(changelog): Update CHANGELOG for 7.38.0
nx.json
Outdated
| "build:types", | ||
| "lint:eslint" | ||
| "lint:eslint", | ||
| "test", |
There was a problem hiding this comment.
Let's maybe only start with caching test:unit, as the integration tests (for example) also make sure stuff keeps working with new versions of e.g. browsers, which is not really deterministic in this way.
WDYT @AbhiPrasad / @Lms24 / @lforst ?
There was a problem hiding this comment.
yes that makes sense to me
There was a problem hiding this comment.
Reverted, I'll leave this one to you to revisit :)
[Gitflow] Merge develop into master
mydea
left a comment
There was a problem hiding this comment.
Versions need updating to current version, then this is good to go - thanks a lot!
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).