build: Generate errors + replay only CDN bundle#7067
Merged
AbhiPrasad merged 4 commits intodevelopfrom Feb 8, 2023
Merged
Conversation
Contributor
Author
|
Hmm, I wonder why the integration tests fail 🤔 |
Lms24
reviewed
Feb 7, 2023
Member
Lms24
left a comment
There was a problem hiding this comment.
LGTM! I think the failing PW tests are more related to the Ubuntu registry problem than the PR...
m: Can we add a size-check entry for the bundle? (feel free to do that in a follow-up PR)
Lms24
approved these changes
Feb 7, 2023
Lms24
approved these changes
Feb 7, 2023
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #7066
Generate CDN bundle (es6 only) for Replay + errors. This gives us all the possible permutations between errors, replays and performance to dynamically load CDN bundle as appropriate for the new loader work.