Skip to content

chore: lerna optimizations#7057

Merged
AbhiPrasad merged 3 commits intogetsentry:developfrom
JamesHenry:lerna-optimizations
Feb 8, 2023
Merged

chore: lerna optimizations#7057
AbhiPrasad merged 3 commits intogetsentry:developfrom
JamesHenry:lerna-optimizations

Conversation

@JamesHenry
Copy link
Copy Markdown
Contributor

@JamesHenry JamesHenry commented Feb 5, 2023 •
edited
Loading

Explainer video below:

Brave.Browser.-.chore_.lerna.optimizations.by.JamesHenry.Pull.Request.7057.getsentry_sentry-javascript.mp4

@JamesHenry
Copy link
Copy Markdown
Contributor Author

JamesHenry commented Feb 6, 2023

Looks like it failed to install playwright... I don't have the right to rerun the CI, please could one of the maintainers do that for me and/or look into the playwright flakiness if it's a new issue?

@AbhiPrasad
Copy link
Copy Markdown
Contributor

AbhiPrasad commented Feb 7, 2023

Looks like it failed to install playwright... I don't have the right to rerun the CI, please could one of the maintainers do that for me and/or look into the playwright flakiness if it's a new issue?

Think the playwright flakiness was due to issues with the ubuntu registry, which have seem to be resolved. Ci is now passing 🥳!

@JamesHenry JamesHenry marked this pull request as ready for review February 7, 2023 15:12
@JamesHenry
Copy link
Copy Markdown
Contributor Author

JamesHenry commented Feb 7, 2023

Thanks a lot @AbhiPrasad!

I've attached an off the cuff video walkthrough of the PR in the description. Hopefully it's useful!

cc @bruno-garcia @mydea

AbhiPrasad
AbhiPrasad approved these changes Feb 8, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes make a lot of sense to me, and we need to take some time to now look at our testing setup now as well.

Thanks for your contribution @JamesHenry!

@AbhiPrasad AbhiPrasad merged commit 2a09fd6 into getsentry:develop Feb 8, 2023
@JamesHenry JamesHenry deleted the lerna-optimizations branch February 8, 2023 13:06
@JamesHenry
Copy link
Copy Markdown
Contributor Author

JamesHenry commented Feb 8, 2023

Awesome, thanks @AbhiPrasad! Again, feel free to reach out with any follow up questions or issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JamesHenry @AbhiPrasad