Skip to content

test(nextjs): Refactor server-side integration tests#6909

Merged
lforst merged 10 commits intomasterfrom
onur/nextjs-new-server-integration-tests
Jan 25, 2023
Merged

test(nextjs): Refactor server-side integration tests#6909
lforst merged 10 commits intomasterfrom
onur/nextjs-new-server-integration-tests

Conversation

@onurtemizkan
Copy link
Copy Markdown
Contributor

@onurtemizkan onurtemizkan commented Jan 23, 2023 •
edited
Loading

Ref: #6053

  • Rewrote current server-side integration tests, to use utilities from the node-integration-tests package.
  • Added a new next.config template / environment configuration for appDir tests.

onurtemizkan
onurtemizkan commented Jan 23, 2023
View reviewed changes
packages/nextjs/test/integration/test/server/doubleEndMethodOnVercel.test.ts
// This test asserts that our wrapping of `res.end` doesn't break API routes on Vercel if people call `res.json` or
// `res.send` multiple times in one request handler.
// https://github.com/getsentry/sentry-javascript/issues/6670
it.skip('should not break API routes on Vercel if people call res.json or res.send multiple times in one request handler', async () => {
Copy link
Copy Markdown
Contributor Author

@onurtemizkan onurtemizkan Jan 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test randomly fails with ERR_STREAM_WRITE_AFTER_END, not sure if it's the testing environment or the case in #6099 still happens.

Copy link
Copy Markdown
Contributor

@lforst lforst Jan 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think this is an actual bug in the SDK

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 23, 2023 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.83 KB (0%)
@sentry/browser - ES5 CDN Bundle (minified) 61.48 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.5 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified) 54.79 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.22 KB (0%)
@sentry/browser - Webpack (minified) 66.19 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.25 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.54 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.76 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.03 KB (-0.01% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 43.57 KB (-0.01% 🔽)
@sentry/replay - Webpack (gzipped + minified) 38.31 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 60.91 KB (-0.01% 🔽)

@onurtemizkan onurtemizkan force-pushed the onur/nextjs-new-server-integration-tests branch 3 times, most recently from 7abc57f to 5fb8ac2 Compare January 24, 2023 11:19
@onurtemizkan onurtemizkan force-pushed the onur/nextjs-new-server-integration-tests branch 2 times, most recently from 2ecc14b to e6b9f4d Compare January 25, 2023 11:53
@onurtemizkan onurtemizkan force-pushed the onur/nextjs-new-server-integration-tests branch from e6b9f4d to be99114 Compare January 25, 2023 12:28
@onurtemizkan onurtemizkan requested review from AbhiPrasad and lforst and removed request for AbhiPrasad January 25, 2023 12:52
@onurtemizkan onurtemizkan marked this pull request as ready for review January 25, 2023 12:53
@onurtemizkan onurtemizkan mentioned this pull request Jan 25, 2023
Closed
5 tasks
@onurtemizkan onurtemizkan self-assigned this Jan 25, 2023
@lforst
Copy link
Copy Markdown
Contributor

lforst commented Jan 25, 2023

Thanks Onur!

@lforst lforst changed the title test(nextjs): New server-side integration tests. test(nextjs): Refactor server-side integration tests Jan 25, 2023
@lforst lforst merged commit d984d7a into master Jan 25, 2023
@lforst lforst deleted the onur/nextjs-new-server-integration-tests branch January 25, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AbhiPrasad AbhiPrasad Awaiting requested review from AbhiPrasad

1 more reviewer

@lforst lforst lforst approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@onurtemizkan onurtemizkan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@onurtemizkan @lforst