feat(replay): Update rrweb & rrweb-snapshot#6749
Merged
Conversation
Contributor
size-limit report 📦
|
billyvg
approved these changes
Jan 12, 2023
Member
billyvg
left a comment
There was a problem hiding this comment.
Let's merge this but we should consider releasing this as a package on npm going forward
Lms24
approved these changes
Jan 12, 2023
Member
Lms24
left a comment
There was a problem hiding this comment.
Just because I'm super paranoid about this stuff: Did you test this in a test app?
Member
Author
|
I tried it in a small test app of mine, and it appeared all fine to me. (But of course this does not test everything) |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates rrweb & rrweb-snapshot to the latest patched version from here: https://github.com/getsentry/rrweb/tree/sentry-v1
Steps:
yarn && yarn build:allin rrwebdist,es,lib&typesfolders from rrweb/rrweb-snapshot into sentry-javascriptnpx patch-package rrweb/npx patch-package rrweb-snapshotin sentry-javascriptYou can see that it is rather hard to grasp and follow, but I think it is what we want here.