feat(core): Add getSdkMetadata to Client#6643
Merged
Conversation
Contributor
size-limit report 📦
|
lforst
approved these changes
Jan 3, 2023
2de4211 to
9082753
Compare
lforst
approved these changes
Jan 3, 2023
2dc6ae8 to
c3051e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new method to the
Clientinterface:getSdkMetadata.We can use this method in the Replay package to avoid accessing
client.getOptions()._metadata, which previously caused broken CDN bundles which we hot-fixed with #6600. This PR now properly fixes this issue by simply not accessing this "private" field anymore.Since adding a new method to the
ClientInterface is a breaking change, I made it an optional method, which should avoid breakage. We should consider making this method required in v8.I tested the Replay CDN bundles with this change to ensure that we still send events.
Note: I'm curious about the bundle size impact here, for example, if the added cost is ammortized by mangling_metadatanow again. Hence leaving this as a draft for now.So, turns out, there is a size increase but given that it seems to be <0.1% I'd vote to go forward with this change.