fixed(profiling): Added missing option type#6310
Closed
zhiyan114 wants to merge 1 commit intogetsentry:masterfrom
Closed
fixed(profiling): Added missing option type#6310zhiyan114 wants to merge 1 commit intogetsentry:masterfrom
zhiyan114 wants to merge 1 commit intogetsentry:masterfrom
Conversation
AbhiPrasad
reviewed
Nov 28, 2022
Contributor
|
@JonasBa - we'll need to update the sentry-docs for this option as well right? |
Member
|
@AbhiPrasad I actually opened a PR just now before seeing this - #6318 Tldr we can accept either @zhiyan114's PR or mine. I moved the profileSampleRate under |
Contributor
|
Hey @zhiyan114 thanks for your contribution. We ended up merging #6318 to do this, but we'll be sure to mention you in our changelog! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a missing client configuration type:
profilesSampleRate.