feat(otel): Add @opentelemetry/core package#6108
Merged
AbhiPrasad merged 2 commits intomasterfrom Nov 2, 2022
Merged
Conversation
This is needed for the propogator functionality.
5 tasks
Member
|
yeah, this is the same as with |
mydea
reviewed
Nov 2, 2022
| }, | ||
| "devDependencies": { | ||
| "@opentelemetry/api": "^1.2.0", | ||
| "@opentelemetry/core": "^1.7.0", |
Member
There was a problem hiding this comment.
m: I think we can only add this to peerDependencies and leave it as a transitive dependency in dev deps. but also OK to add it explicitly, I guess! If we want to leave it here, we should also add @opentelemetry/semantic-conventions as devDependency for symmetry!
mydea
approved these changes
Nov 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: #6107
Not a 100% sure about adding this as a peer dep, since this will by included as a child dep of
@opentelemetry/sdk-trace-base