ref(nextjs): Simplify rollupize in proxy loader#6020
Merged
lobsterkatie merged 4 commits intomasterfrom Oct 24, 2022
Merged
Conversation
AbhiPrasad
approved these changes
Oct 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes a few small changes to the
rollupizefunction used by the nextjs SDK's proxy loader:rollupizeand then handling an undefinedrollupizereturn value in the proxy loader.makeAbsoluteExternalsRelativegetRollupInputOptionswhich seems no longer to be needed. (It was never clear why it was necessary in the first place, and TS no longer seems mad when it's removed.)resourcePathtouserModulePathfor clarityThe latter two changes are drawn from #5960, to preserve them even though it is being reverted.