feat(tracing): Update to Web Vitals v3#5987
Merged
AbhiPrasad merged 10 commits intogetsentry:masterfrom Oct 24, 2022
Merged
Conversation
Contributor
|
Let's make sure we update https://github.com/getsentry/sentry-javascript/blob/master/packages/tracing/src/browser/web-vitals/README.md as well. |
AbhiPrasad
reviewed
Oct 21, 2022
Contributor
AbhiPrasad
left a comment
There was a problem hiding this comment.
Reminder that we’ll need to update the readme in the web-vitals folder!
Collaborator
Author
Was just on my way to do that and noticed they've already released 3.0.4 with a bug fix so I'll try and get that in first! |
This was referenced Oct 24, 2022
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5462
This merges in changes from Web Vitals v3.0.4 while maintaining the original changes and simplifications to the vendored code.
I have not carried across the file renames (ie.
getXXX>onXXX) yet because they're not displayed as renames in the diffs.Below is the web vitals changelog with the items I consider not relevant to this vendored code crossed out. The major change which probably needs considering in tracing is that it now detects prerendered pages. That PR suggests that these page loads should be considered differently to regular page loads since the metrics are likely to vary.
v3.0.3 (2022-10-04)
Ensureattributionobject is always present in attribution build (#265)v3.0.2 (2022-09-14)
Set an explicit unpkg dist file (#261)v3.0.1 (2022-08-31)
Use the cjs extension for all UMD builds (#257)v3.0.0 (2022-08-24)
[BREAKING] Add a config object param to all metric functions (#225)[BREAKING] Report TTFB after a bfcache restore (#220)Update the metric ID prefix for v3 (#251)Move the Navigation Timing API polyfill to the base+polyfill build (#248)Add a metric rating property (#246)Add deprecation notices for base+polyfill builds (#242)Add a new attribution build for debugging issues in the field (#237, #244)Rename the(Add a config object param to all metric functions GoogleChrome/web-vitals#225), #227)ReportHandlertype toReportCallback, with alias for back-compat ([Fix Tracekit for firefox/xulrunner chrome code #225]Add support for the new INP metric (#221, #232)RenamegetXXX()functions toonXXX()(#222)navigationTypeproperty to the Metric object (#219)v2.1.4 (2022-01-20)
Prevent TTFB from reporting after bfcache restore (#201)v2.1.3 (2022-01-06)
v2.1.2 (2021-10-11)
Ensure reported TTFB values are less than the current page time (#187)v2.1.1 (2021-10-06)
Add feature detects to support Opera mini in extreme data saver mode (#186)